Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add barrel file #132

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

jgornick
Copy link
Contributor

@jgornick jgornick commented Nov 28, 2022

What:

Re-added barrel file in src directory. Also added npm script (generate-barrels).
Resolves #130

Why:

Unable to import matchers for use in a library.

How:

Used barrelsby to generate barrel file.

Checklist:

  • Documentation added to the docs
  • Typescript definitions updated
  • Tests
  • Ready to be merged

@jgornick jgornick force-pushed the 130-add-barrel-file branch from fcdc19c to 9cf14ab Compare December 8, 2022 15:49
@jgornick
Copy link
Contributor Author

jgornick commented Dec 8, 2022

Bump ^^^

cc @mdjastrzebski

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #132 (9cf14ab) into main (d65e9f2) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cf14ab differs from pull request most recent head 35697b0. Consider uploading reports for the commit 35697b0 to get more accurate results

@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          224       224           
  Branches        70        70           
=========================================
  Hits           224       224           
Flag Coverage Δ
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdjastrzebski
Copy link
Collaborator

@jgornick Would adding src/index.ts alone resolve your issue? I am wary about including additional deps like barelsby if not strictly needed.

@mdjastrzebski mdjastrzebski changed the title fix: add barrel file and scripts to generate fix: add barrel file Dec 15, 2022
@mdjastrzebski
Copy link
Collaborator

Removed barrelsby dep, but kept the src/index.ts file.

@mdjastrzebski mdjastrzebski merged commit fafd6ed into testing-library:main Dec 15, 2022
@github-actions
Copy link

🎉 This PR is included in version 5.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jgornick
Copy link
Contributor Author

I'm sorry for not following up on this @mdjastrzebski. I appreciate you though doing the work and getting it merged in!

@jgornick jgornick deleted the 130-add-barrel-file branch December 19, 2022 17:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing (dist) index.js which exports all matchers for library usage
2 participants