Skip to content

fix: make default oembed panes equal to embed modal #292

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Oct 31, 2020

Conversation

MichaelDeBoey
Copy link
Member

I think we should make the default panes of the embed consistent with the default panes from the embed modal

@smeijer smeijer added the bug Something isn't working label Oct 31, 2020
@smeijer smeijer changed the title fix: Bring embed panes in line with the embed in the GUI fix: bring embed panes in line with the embed in the GUI Oct 31, 2020
@MichaelDeBoey MichaelDeBoey force-pushed the update-embed-panes branch 3 times, most recently from 398c174 to a81ecd9 Compare October 31, 2020 16:30
@smeijer smeijer force-pushed the update-embed-panes branch from 741f48e to e427d61 Compare October 31, 2020 16:38
@smeijer smeijer merged commit 82c7b16 into testing-library:develop Oct 31, 2020
@smeijer smeijer changed the title fix: bring embed panes in line with the embed in the GUI fix: make default oembed panes equal to embed modal Oct 31, 2020
@MichaelDeBoey MichaelDeBoey deleted the update-embed-panes branch October 31, 2020 17:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants