Review fixes

- use InstanceCreator#newInstance()
- use TestNG exception with detail exception message
- create and link github issue

CHANGES.txt

@@ -1,5 +1,5 @@
 Current
-New: Yaml parser: implement loadClasses flag (Dzmitry Sankouski)
+Fixed: GITHUB-2689: Yaml parser: implement loadClasses flag (Dzmitry Sankouski)
 Fixed: GITHUB-2676: NPE is triggered when working with ITestObjectFactory (Krishnan Mahadevan)
 Fixed: GITHUB-2674: Run onTestSkipped for each value from data provider (Krishnan Mahadevan)
 Fixed: GITHUB-2672: Log real stacktrace when test times out. (cdalexndr)

testng-core/src/main/java/org/testng/internal/Yaml.java

@@ -8,6 +8,7 @@
 import java.util.Map;
 import java.util.function.Consumer;
 import org.testng.TestNGException;
+import org.testng.internal.objects.InstanceCreator;
 import org.testng.util.Strings;
 import org.testng.xml.XmlClass;
 import org.testng.xml.XmlInclude;
@@ -378,13 +379,13 @@ public Object newInstance(Node node) {
                           nodeTuple ->
                               ((ScalarNode) nodeTuple.getKeyNode()).getValue().equals("name"))
                       .findFirst()
-                      .orElseThrow(RuntimeException::new)
+                      .orElseThrow(() -> new TestNGException("Node 'name' not found"))
                       .getValueNode();
           className = ((ScalarNode) valueNode).getValue();
         } else {
           className = ((ScalarNode) node).getValue();
         }
-        return c.newInstance(className, loadClasses);
+        return InstanceCreator.newInstance(c, className, loadClasses);
       } catch (Exception e) {
         throw new TestNGException("Failed to instantiate class", e);
       }

testng-core/src/test/java/test/yaml/YamlTest.java

@@ -72,7 +72,7 @@ public void testXmlDependencyGroups() throws IOException {
     assertThat(Yaml.toYaml(actualXmlSuite).toString()).isEqualToNormalizingNewlines(expectedYaml);
   }
 
-  @Test
+  @Test(description = "GITHUB-2689")
   public void testLoadClassesFlag() throws IOException {
     YamlParser yamlParser = new YamlParser();
     String yamlSuiteFile = "src/test/resources/yaml/suiteWithNonExistentTest.yaml";