Ensure that all tests only run on the files they should run on

[ChrisChinchilla]

No description provided.

[ChrisChinchilla]

I have made some changes to this @svx

At the moment if you specify a file it test that file, if you specify nothing it checks the whole directory. But really we should match the usage here - https://github.com/errata-ai/vale#usage and due to the Docker mapping this starts to get complicated, so I'm not really sure of the best way to proceed tbh.

[svx]

@ChrisChinchilla What do you mean ?
Do you mean the possibility to use a own .vale.ini file ?

[ChrisChinchilla]

When we first planned this we meant the ability to specify what MD, rst files to check when you run the redactor command, but now I think about it, with the changes I pushed to the Vale file type day, maybe that's enough. It still just checks everything that matches in the folder specified, but for our use case, maybe that works.

Ah well, had fun playing with the code.

[svx]

@ChrisChinchilla I do not understand what you are doing here.
Maybe we are talking about different things, ideas or implementations ?

That is also why I do not get why you changed the vale.go in redactor.

Like I said I am not sure if we are talking about the same way of implementation here.

Let me explain how this works in my idea and how it is written and implemented.

First, rakpart and redactor are not certainly depending on each other.
Yes, I use rakpart as a base for checks, which I use in redactor, but you can also hook up every other test as long as it is a valid docker/oci image.

You can use rakpart checks, but you do not have to, I use for example lots of the rakpart checks, "standalone" or in scripts, makefiles or on CI.

The configuration of redactor is done via a toml/yaml file, where you configure checks and settings.
It is not intended (at least I have no intention) to do that in any other way, I never had :)

Because of this I do not get why you changed vale.go. ?

Maybe you have other ideas, not sure, but then we have to talk, fork or something else :)

Thanks !

:)

[ChrisChinchilla]

@svx I understand how things are implemented, and our ideas, there's no need to start talking about forks.

This suggestion was purely to address something we discussed at the hackathon. That was instead of redactor checking all files in the path passed, that you can specify files, a glob etc instead to be more selective. To do this, the Dockerfile and vale.go needed changes, as far as I could tell anyway. I am not a Docker or Go expert at all. Also the direction I was going (which is not complete) would have allowed this to be decoupled too.

But as I said above .vale.ini at least allows for some configuration, but still exposing the potential elsewhere might be a nicer user experience. But also as I said above, as we are passing these values between two fundamentally different systems, it's quite complicated and maybe not even worth it.

I don't think I've heard the mention of redactor config file before though, which I'm still not sure would solve this use case or not because the Dockerfile still just receives a folder as far as I can see. But again, maybe we don't even need it anyway.

PS, check twitter, trying to talk to you about something with someone else :)

[ChrisChinchilla]

Or maybe jump on Gitter for some in-real-time chat