Allow field extensions to return None from map_serializer_field #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A field can be marked as ignored when generating by using `@extended_schema_field(None)` or `OpenApiTypes.NONE`. This change extends the Extension processing so its behavior matches the decorator.
tfranzel
added a commit
that referenced
this pull request
Oct 5, 2022
|
thanks for the PR @awbacker. just solved a minor issue in the tests where you collided with another extension test. resolved it by giving your test it's own field test class. |
|
Thanks you. Sorry I didn't notice that the PR was going directly here, thought I had time. And... i was just going to close that issue too, or comment. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A field can be marked as ignored when generating by using
@extended_schema_field(None)orOpenApiTypes.NONE. This change extends the Extension processing so its behavior matches the decorator.