Missing getcwd function?

[kasperg]

Thanks a bunch for sharing safe. It helps me up my PHPStan level without writing to much tedious code.

One question: Is the getcwd() function missing?

I tried looking into this and the documentation seems as if it would be detected as falsy and as far as I can tell neither module nor function is explicitly declared as ignored.

Returns the current working directory on success, or FALSE on failure.

I tried running the generation but cloning the documentation fails because of timeouts 😕 .

[moufmouf]

Yeah... I'm having the same problem right now. The documentation SVN seems to be down since approximately one hour. Hopefully, it will be fixed soon.

[moufmouf]

Regarding getcwd, you are perfectly right, it should be detected.

Detection is done in DocPage::detectFalsyFunction:

safe/generator/src/DocPage.php

Lines 26 to 48 in 726b999

	public function detectFalsyFunction(): bool
	{
	$file = file_get_contents($this->path);
	if (!preg_match('/::/m', $file)) {
	if (preg_match('/&false;\s+on\s+error/m', $file)) {
	return true;
	}
	if (preg_match('/&false;\s+if\s+an\s+error\s+occurred/m', $file)) {
	return true;
	}
	if (preg_match('/&return.success;/m', $file)) {
	return true;
	}
	if (preg_match('/&return.nullorfalse;/m', $file)) {
	return true;
	}
	if (preg_match('/&return.falseforfailure;/m', $file)) {
	return true;
	}
	}
	return false;
	}

It is really heuristic as the doc can be written in a lot of different ways.

I'll fix this for getcwd

[kasperg]

I took a stab at this myself. We can continue the discussion in the PR.