Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Default value for wasm-opt on default rust app is incorrect #209

Closed
thedodd opened this issue Aug 3, 2021 · 1 comment · Fixed by #211
Closed

Default value for wasm-opt on default rust app is incorrect #209

thedodd opened this issue Aug 3, 2021 · 1 comment · Fixed by #211
Labels
bug Something isn't working

Comments

@thedodd
Copy link
Member

thedodd commented Aug 3, 2021

When not explicitly defining the <link data-trunk rel="rust" .../> tag, the default value for wasm-opt is not set to None as it should be.

@thedodd thedodd added the bug Something isn't working label Aug 3, 2021
@thedodd
Copy link
Member Author

thedodd commented Aug 3, 2021

cc @Follpvosten for finding this bug :)

thedodd added a commit that referenced this issue Aug 4, 2021
Cut over to notify@0.5.0-pre.11. Much more simple interface, and works
quite nicely with the async ecosystem.

Cut over to axum for web server. Much better!

The updated server stack is now more intelligently handling 404s. This
is a common issue where users may end up making a request for some
non-html static asset, but they get their path slightly wrong and are
served the index.html instead of a 404.

This typically results in users struggling to find the problem, and
often times users have opened issues in GH. This updated algorithm will
now evaluate 404s more closely and only respond with the index.html when
the `accept` header allows for text/html or */*.

Added an example demonstrating all proxy functionality.

closes #198
closes #209
thedodd added a commit that referenced this issue Aug 4, 2021
Cut over to notify@0.5.0-pre.11. Much more simple interface, and works
quite nicely with the async ecosystem.

Cut over to axum for web server. Much better!

The updated server stack is now more intelligently handling 404s. This
is a common issue where users may end up making a request for some
non-html static asset, but they get their path slightly wrong and are
served the index.html instead of a 404.

This typically results in users struggling to find the problem, and
often times users have opened issues in GH. This updated algorithm will
now evaluate 404s more closely and only respond with the index.html when
the `accept` header allows for text/html or */*.

Added an example demonstrating all proxy functionality.

closes #198
closes #209
thedodd added a commit that referenced this issue Aug 4, 2021
Cut over to notify@0.5.0-pre.11. Much more simple interface, and works
quite nicely with the async ecosystem.

Cut over to axum for web server. Much better!

The updated server stack is now more intelligently handling 404s. This
is a common issue where users may end up making a request for some
non-html static asset, but they get their path slightly wrong and are
served the index.html instead of a 404.

This typically results in users struggling to find the problem, and
often times users have opened issues in GH. This updated algorithm will
now evaluate 404s more closely and only respond with the index.html when
the `accept` header allows for text/html or */*.

Added an example demonstrating all proxy functionality.

closes #198
closes #202
closes #209
thedodd added a commit that referenced this issue Aug 4, 2021
Cut over to notify@0.5.0-pre.11. Much more simple interface, and works
quite nicely with the async ecosystem.

Cut over to axum for web server. Much better!

The updated server stack is now more intelligently handling 404s. This
is a common issue where users may end up making a request for some
non-html static asset, but they get their path slightly wrong and are
served the index.html instead of a 404.

This typically results in users struggling to find the problem, and
often times users have opened issues in GH. This updated algorithm will
now evaluate 404s more closely and only respond with the index.html when
the `accept` header allows for text/html or */*.

Added an example demonstrating all proxy functionality.

closes #198
closes #202
closes #209
thedodd added a commit that referenced this issue Aug 5, 2021
Cut over to notify@0.5.0-pre.11. Much more simple interface, and works
quite nicely with the async ecosystem.

Cut over to axum for web server. Much better!

The updated server stack is now more intelligently handling 404s. This
is a common issue where users may end up making a request for some
non-html static asset, but they get their path slightly wrong and are
served the index.html instead of a 404.

This typically results in users struggling to find the problem, and
often times users have opened issues in GH. This updated algorithm will
now evaluate 404s more closely and only respond with the index.html when
the `accept` header allows for text/html or */*.

Added an example demonstrating all proxy functionality.

closes #198
closes #202
closes #209
thedodd added a commit that referenced this issue Aug 5, 2021
Cut over to notify@0.5.0-pre.11. Much more simple interface, and works
quite nicely with the async ecosystem.

Cut over to axum for web server. Much better!

The updated server stack is now more intelligently handling 404s. This
is a common issue where users may end up making a request for some
non-html static asset, but they get their path slightly wrong and are
served the index.html instead of a 404.

This typically results in users struggling to find the problem, and
often times users have opened issues in GH. This updated algorithm will
now evaluate 404s more closely and only respond with the index.html when
the `accept` header allows for text/html or */*.

Added an example demonstrating all proxy functionality.

closes #198
closes #202
closes #209
thedodd added a commit that referenced this issue Aug 5, 2021
Cut over to notify@0.5.0-pre.11. Much more simple interface, and works
quite nicely with the async ecosystem.

Cut over to axum for web server. Much better!

The updated server stack is now more intelligently handling 404s. This
is a common issue where users may end up making a request for some
non-html static asset, but they get their path slightly wrong and are
served the index.html instead of a 404.

This typically results in users struggling to find the problem, and
often times users have opened issues in GH. This updated algorithm will
now evaluate 404s more closely and only respond with the index.html when
the `accept` header allows for text/html or */*.

Added an example demonstrating all proxy functionality.

closes #198
closes #202
closes #209
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant