Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Compensate for differences between cargo bin vs lib output names #58

Closed
thedodd opened this issue Sep 23, 2020 · 1 comment
Closed

Compensate for differences between cargo bin vs lib output names #58

thedodd opened this issue Sep 23, 2020 · 1 comment
Assignees
@thedodd
Labels
bug Something isn't working
Milestone
0.5.x | Proxy System

Comments

@thedodd
Copy link
Member

thedodd commented Sep 23, 2020

A few things to consider here:

  • probably want to stick with the manual invocation of cargo, as we want to output any errors to the console exactly as one would see them in their shell normally.
  • need to account for the differences between bin and lib output names from cargo.
@thedodd thedodd added the bug Something isn't working label Sep 23, 2020
@thedodd thedodd self-assigned this Sep 23, 2020
@thedodd thedodd mentioned this issue Sep 23, 2020
Closed
@thedodd thedodd added this to the 0.5.[0-2] | Proxy System milestone Sep 23, 2020
@hobofan
Copy link

hobofan commented Sep 25, 2020

Not sure if that was already meant with this issue, but I ran into this when trying to move yew-react-example to trunk. The problem here was that the crate name contains dashes which are automatically converted to underscores in the target .wasm file name, which I guess is quite common.

Coupled with the sparse logging and the fact that the old lib.rs before converting it to main.rs had already produced a correctly named .wasm file that was being picked up instead of the new one made this a very annoying problem to debug, and one that I would expect many people that are converting existing projects to trunk to run into.

thedodd added a commit that referenced this issue Sep 28, 2020
@thedodd
Major refactor of code layout and structure.
e319814 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example.

Add snapshot tests over the yew example app.

closes #58
thedodd added a commit that referenced this issue Sep 28, 2020
@thedodd
Major refactor of code layout and structure.
830639b 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example.

Add snapshot tests over the yew example app.

closes #58
thedodd added a commit that referenced this issue Sep 28, 2020
@thedodd
Major refactor of code layout and structure.
b3dd0c9 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example.

Add snapshot tests over the yew example app.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
bf2aa14 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
9ef6ea4 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
c1e5b50 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
8d14a58 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
5efa464 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
d4e0791 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
25859dd 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
6d697f4 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
231dd94 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
face4d6 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
e48cedf 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
d59b660 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
61311fc 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
thedodd added a commit that referenced this issue Sep 30, 2020
@thedodd
Major refactor of code layout and structure.
8666a08 
This should allow for a much easier process of adding new pipelines and
assets to the mix. Functionality has been preserved. A few small bug
fixes have been factored in.

Add a Trunk, Yew, YBC (Bulma) example. This includes a minimal
Trunk.toml.

Add snapshot tests over the yew example app.

Added a pull request template, just to help folks remember to knock out
a few of the small tasks associated with getting PRs to land.

Broke apart the config.rs module into a directory of a few separate
modules under src/config. The file was getting fairly large and had
three distinct families of types.

Simplified the handling of errors in main. This handles returning proper
status codes and also prints out the chain of errors associated with the
error being logged.

The processing of Trunk.toml files has been updated to ensure that all
paths declared in the file will be treated as relative to the config
file itself (if the paths are indeed relative).

Introduced CI caching.

closes #58
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@thedodd thedodd

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.x | Proxy System
Development

No branches or pull requests
2 participants
@hobofan @thedodd