Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set directories to watch other than the current directory #93

Closed
ranile opened this issue Nov 17, 2020 · 4 comments · Fixed by #94
Closed

Set directories to watch other than the current directory #93

ranile opened this issue Nov 17, 2020 · 4 comments · Fixed by #94
Labels
cli Trunk CLI application enhancement New feature or request good first issue Good for newcomers

Comments

@ranile
Copy link
Contributor

ranile commented Nov 17, 2020

trunk currently doesn't allow users to set directories to watch.

This becomes an annoyance when when serving test/example apps for libraries where the library code may not be in the same directory as the app we're serving. In such situations, we have to re-start trunk. This can be solved if we can set what directories to watch in addition to the current working directory.

@thedodd thedodd added cli Trunk CLI application enhancement New feature or request good first issue Good for newcomers labels Nov 17, 2020
@malobre
Copy link
Contributor

malobre commented Nov 28, 2020

I'm working on an app that is composed of 3 crates in a single workspace, only one of these is built by trunk but it watches all 3 folders.

Something like this would be nice:

[watch]
include = ["./path"] # Meaning: Only watch './path', an empty array would mean watch current directory
exclude = ["./path/to/folder"] # But exclude this subfolder

@malobre
Copy link
Contributor

malobre commented Nov 28, 2020

@thedodd I can have a go at this if you want.

@thedodd
Copy link
Member

thedodd commented Nov 28, 2020

@malobre that sounds good to me! It will be a solid feature to add. Keep me posted. Happy to help in any way.

@malobre
Copy link
Contributor

malobre commented Nov 28, 2020

I've begin working on this in #94.

If I have any question I'll ping you in the PR.

@malobre malobre mentioned this issue Nov 30, 2020
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cli Trunk CLI application enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants