Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change grunt folder to tasks #22

Merged
merged 1 commit into from
May 3, 2013
Merged

Change grunt folder to tasks #22

merged 1 commit into from
May 3, 2013

Conversation

milesj
Copy link
Contributor

@milesj milesj commented May 2, 2013

To make use of task loading in NPM:

grunt.loadNpmTasks('intern');

The folder name must be tasks, according to the grunt source code.

  // Process task plugins.
  var tasksdir = path.join(root, name, 'tasks');
  if (grunt.file.exists(tasksdir)) {
    loadTasks(tasksdir);
  } else {
    grunt.log.error('Local Npm module "' + name + '" not found. Is it installed?');
  }

@csnover
Copy link
Member

csnover commented May 3, 2013

Congratulations on having the distinction of submitting the first (non-spam) community PR! :)

By the way, have you signed the Dojo Foundation CLA? It will only take a minute, but if you plan on submitting any more non-trivial fixes or enhancements in the future, it will be needed for them to be accepted.

@milesj
Copy link
Contributor Author

milesj commented May 3, 2013

Looks like I've already accepted the terms before!

@csnover
Copy link
Member

csnover commented May 3, 2013

I’ve recently been informed that there was an error in the form that caused the duplicate registration message to be displayed incorrectly for people that submitted the form without a Dojo Foundation account. If you submit it again now, it should go through, properly this time. Really sorry for the hassle. If you want to wait until you actually submit another PR, I completely understand.

@milesj
Copy link
Contributor Author

milesj commented May 3, 2013

I still get the "The username or email address provided is already on file. Only one CLA needs to be filed per username/email address." message.

@csnover csnover merged commit eb25a1e into theintern:master May 3, 2013
@csnover
Copy link
Member

csnover commented May 3, 2013

@vladikoff this issue is relevant to your interests now that it has landed. :)

@milesj I swear if you try the form again it will work now (I personally tested it). It seems that sqlite pretends to drop indexes with unique constraints but actually doesn’t drop the constraints even though the index is gone.

@vladikoff
Copy link
Member

On it! Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement A new or improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants