Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump grunt-contrib-uglify and pin versions of grunt packages #119

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

astorije
Copy link
Member

Made different tests locally and it seems to work fine (only change is grunt-contrib-uglify) but since this can break publication, I wouldn't be against some more testing from other reviewers :-) (will not set the second review needed label myself for this reason).

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Feb 28, 2016
@xPaw
Copy link
Member

xPaw commented Feb 28, 2016

👍 Since we had ~ and ^ versions already, we unintentionally tested newer version :)

@astorije
Copy link
Member Author

Actually, not quite: all of them but grunt-contrib-uglify still have their stable version matching the versions we have in the package.json.
Only grunt-contrib-uglify changes, as prior to that PR, we were matching 0.5.0 and 0.5.1, while this PR makes it go to 0.11.1. Other are just pinned with no other consequences.

@maxpoulin64
Copy link
Member

Looks fine to me, 👍 I'm not a fan of pinning versions, but as discussed with @astorije on IRC on the long term it's the safer approach. Lets just not forget to keep them updated once in a while not to fall too far behind :)

astorije added a commit that referenced this pull request Feb 29, 2016
Bump grunt-contrib-uglify and pin versions of grunt packages
@astorije astorije merged commit 8c45cb2 into master Feb 29, 2016
@astorije astorije deleted the astorije/bump-grunt branch February 29, 2016 07:35
@AlMcKinlay
Copy link
Member

Might be worth using libraries.io to make sure we don't fall behind. Emails maintainers when something is updated.

@astorije
Copy link
Member Author

astorije commented Mar 1, 2016

We actually do have a libraries.io page as I contacted them when starting to fix that page which was not working properly...
However, we also use badges from https://david-dm.org/thelounge/lounge, which also works pretty well. Just need to keep an eye on dependencies :-)

@astorije astorije added this to the 1.3.0 milestone Apr 1, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants