Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #116: Move 'you' handling in invites to the client #122

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Fix #116: Move 'you' handling in invites to the client #122

merged 1 commit into from
Mar 1, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Feb 28, 2016

No description provided.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Feb 28, 2016
@astorije astorije self-assigned this Feb 29, 2016
@astorije
Copy link
Member

@xPaw, does the client have a reference to the user's nick? If so, we could have the equality check in the template directly rather than passing that invitedYou in the event. If not, nevermind then.

@astorije
Copy link
Member

Marking with priority label here: it's a regression compared to the latest release, v1.2.1, so let's not ship that in the next release.

@maxpoulin64
Copy link
Member

👍

@astorije
Copy link
Member

Will +1 and merge when @xPaw addresses (or not) my comment above :-)

@xPaw
Copy link
Member Author

xPaw commented Feb 29, 2016

It does not have a reference.

On Mon, 29 Feb 2016, 08:50 Jérémie Astori, notifications@github.com wrote:

Will +1 and merge when @xPaw https://github.com/xPaw addresses (or not)
my comment above :-)


Reply to this email directly or view it on GitHub
#122 (comment).

astorije added a commit that referenced this pull request Mar 1, 2016
Fix #116: Move 'you' handling in invites to the client
@astorije astorije merged commit 325739c into thelounge:master Mar 1, 2016
@xPaw xPaw deleted the odd-invite branch March 7, 2016 17:17
@astorije astorije added this to the 1.3.0 milestone Apr 1, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants