Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Link to lounge demo from irc badge #203

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Link to lounge demo from irc badge #203

merged 1 commit into from
Mar 18, 2016

Conversation

Henni
Copy link
Contributor

@Henni Henni commented Mar 17, 2016

Just a small change for the README

@MaxLeiter
Copy link
Member

Might be bias, but 👍 from me. Not everyone looks at the website.

Maybe change "#TheLounge channel on freenode" to just "IRC demo" or something?

@AlMcKinlay
Copy link
Member

Yeah, I don't see why not, the demo puts people into #thelounge doesn't it? 2 birds, 1 stone.

@maxpoulin64 maxpoulin64 added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. second review needed labels Mar 17, 2016
@maxpoulin64
Copy link
Member

Yeah sounds good to me too, 👍

@astorije
Copy link
Member

One of the reasons why we couldn't do that on https://github.com/erming/shout was that the demo is connecting to a test IRC server and locked to it. We'll probably want to do that as we attract more users, but in the meantime, this is good enough: 👍.

@MaxLeiter, do you mind locking the demo to Freenode, then?

astorije added a commit that referenced this pull request Mar 18, 2016
Link to lounge demo from irc badge
@astorije astorije merged commit bbeeeda into thelounge:master Mar 18, 2016
@astorije astorije self-assigned this Mar 18, 2016
@MaxLeiter
Copy link
Member

It already is, @astorije (thanks to @xPaw for implementing locking networks)

@astorije
Copy link
Member

My bad, I didn't realize it was the case on the demo!

@Henni Henni deleted the patch-1 branch March 19, 2016 08:54
@astorije astorije modified the milestones: 2.3.0, 1.4.0 Apr 1, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants