Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add hostmasks in logs when possible #670

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Conversation

astorije
Copy link
Member

@astorije astorije commented Oct 3, 2016

This will augment logs for join/part/quit with something similar to:

[2016-10-03 23:19:29] * astorije2 (~lounge-us@123.45.67.89) join
[2016-10-03 23:22:04] * foobar (~foo@irc.example.com) join

[2016-10-03 23:22:00] * foo (foo@gateway/web/freenode/ip.12.34.56.789) quit Quit: Page closed
[2016-10-03 23:22:12] * bar (~foo@unaffiliated/bar) quit Ping timeout: 252 seconds

[2016-10-03 23:31:23] * astorije (~astorije@128.30.0.0) part

Also switched line concatenating to ES6 templates because it's the future, baby.

This will augment logs for `join`/`part`/`quit` with something similar to:

```
[2016-10-03 23:19:29] * astorije2 (~lounge-us@123.45.67.89) join
[2016-10-03 23:22:04] * foobar (~foo@irc.example.com) join

[2016-10-03 23:22:00] * foo (foo@gateway/web/freenode/ip.12.34.56.789) quit Quit: Page closed
[2016-10-03 23:22:12] * bar (~foo@unaffiliated/bar) quit Ping timeout: 252 seconds

[2016-10-03 23:31:23] * astorije (~astorije@128.30.0.0) part
```
@astorije astorije added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. second review needed labels Oct 3, 2016
@xPaw xPaw merged commit da215d5 into master Oct 7, 2016
@xPaw xPaw deleted the astorije/hostmask-in-logs branch October 7, 2016 16:38
@xPaw xPaw added this to the 2.1.0 milestone Oct 7, 2016
@xPaw xPaw self-assigned this Oct 7, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…logs

Add hostmasks in logs when possible
@xPaw xPaw removed their assignment Mar 12, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants