Fix /mode command to correctly assume target #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
xPaw
commented
Oct 8, 2016
|
|
||
| return true; | ||
| network.irc.raw.apply(network.irc, args); |
There was a problem hiding this comment.
... spread operator is not supported in node4.
xPaw
commented
Oct 8, 2016
| } | ||
|
|
||
| if (args.length === 0 || args[0][0] === "+" || args[0][0] === "-") { | ||
| args.unshift(chan.type === Chan.Type.CHANNEL || chan.type === Chan.Type.QUERY ? chan.name : network.nick); |
There was a problem hiding this comment.
Not sure if there's any use of allowing query targets here.
xPaw
force-pushed
the
xpaw/fix-mode-command
branch
from
93be5ed to
108c2a7
Compare
xPaw
force-pushed
the
xpaw/fix-mode-command
branch
from
108c2a7 to
93053d4
Compare
astorije
reviewed
Oct 17, 2016
| nick: "xPaw", | ||
| irc: { | ||
| raw: function() { | ||
| testableNetwork.lastCommand = Array.prototype.join.call(arguments, " "); |
There was a problem hiding this comment.
Nice trick to get the latest command called!
astorije
reviewed
Oct 17, 2016
| // Multiple arguments are supported, sent as separate commands | ||
| ModeCommand.input(testableNetwork, channel, "devoice", ["xPaw", "Max-P"]); | ||
| expect(testableNetwork.lastCommand).to.equal("MODE #thelounge -v Max-P"); | ||
| }); |
There was a problem hiding this comment.
I'd rather see these broken up in multiple expects (can be grouped in a common describe), but really no big deal, especially at that point.
Awesome job on adding tests though!!
astorije
approved these changes
Oct 17, 2016
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Fix /mode command to correctly assume target
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #676 and #223.
Also adds support for passing in multiple nicks into
/op(and other short commands). Adds a/hopand/dehopaliases.