Add a UI element to cycle through nick completions on mobile #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
maxpoulin64
approved these changes
Oct 22, 2016
| @@ -1731,6 +1740,11 @@ button { | |||
| #viewport.menu-open { | |||
| transition: none; | |||
| } | |||
|
|
|||
| /* Nick cycler should only be displayed on mobile */ | |||
There was a problem hiding this comment.
Actually, I don't really see any harm into having it available on desktop as well. Makes it easy to discover for people that are not used to the tab mechanic.
This was heavily inspired by maxpoulin64@a877e46. Clearly not a definitive solution but a good start to have and to improve upon.
astorije
force-pushed
the
astorije/nick-cycle
branch
from
81302a5 to
ddaf7ff
Compare
|
@maxpoulin64, made some changes regarding your comment:
Mind confirming/updating your review? |
xPaw
approved these changes
Oct 25, 2016
|
Loses input focus on mobile. Perhaps bypass the mobile detection and just |
Same issue than #483. |
eliemichel
pushed a commit
to eliemichel/lounge
that referenced
this pull request
Aug 31, 2017
Reverts thelounge#708. Fixes thelounge#869. Fixes thelounge#1023.
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Add a UI element to cycle through nick completions on mobile
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Reverts thelounge#708. Fixes thelounge#869. Fixes thelounge#1023.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #339.
This was heavily inspired by maxpoulin64@a877e46.
Clearly not a definitive solution but a good easy start to have and to improve later on.
Result