-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added a section explaining why a fork was created. #95
Conversation
But of a nitpick, but maybe “Why the fork?” sounds better? |
Thanks, I updated accordingly. |
project (which is a perfectly fine thing!). | ||
|
||
A bunch of people, excited about making things a bit differently than the upstream | ||
project forked it under a new name: «The Lounge». |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/«The Lounge»/"The Lounge"/ :-)
@almet, thanks for this! |
|
||
This forks aims to be community managed, meaning that the decisions are taken | ||
in a collegial fashion, and that a bunch of maintainers should be able to make | ||
the review process more streamlined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"more streamlined—and ideally quicker."
Thoughts, @astorije?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not use words like "should" or "ideally" here actually, but more like "goal(s)", "intent", more present tense. But maybe that doesn't make any sense and therefore you should ignore this comment :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe then, "the review process quicker and more streamlined."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not technically a reviewer, but I am a native English speaker. 😼 Left a couple inline comments of my own. If I was a reviewer, I'd give this a 👍 after @astorije's comments are addressed. |
updated and squashed. |
A bunch of people, excited about doing things a bit differently than the upstream
The fork aims to be community managed Some of my thoughts ^ |
Thanks for your thoughts @MaxLeiter but I believe this is good as is :-) @almet, 👍, thanks for this! |
👍 |
Added a section explaining why a fork was created.
I was wondering why the fork was created, so dropped over IRC had approximately
this answer, that I rephrased and put in a pull request.
I'm actually not sure about the part where I say decisions are taken
collegially, but I would love to see this a reality :-)
Please, don't hesitate to add some more information there in the comments,
I will integrate them in the pull request and hopefully everything will be
merged to master at some point.