Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added a section explaining why a fork was created. #95

Merged
merged 1 commit into from
Feb 28, 2016

Conversation

almet
Copy link
Contributor

@almet almet commented Feb 23, 2016

I was wondering why the fork was created, so dropped over IRC had approximately
this answer, that I rephrased and put in a pull request.

I'm actually not sure about the part where I say decisions are taken
collegially, but I would love to see this a reality :-)

Please, don't hesitate to add some more information there in the comments,
I will integrate them in the pull request and hopefully everything will be
merged to master at some point.

@MaxLeiter
Copy link
Member

But of a nitpick, but maybe “Why the fork?” sounds better?

@almet
Copy link
Contributor Author

almet commented Feb 23, 2016

Thanks, I updated accordingly.

project (which is a perfectly fine thing!).

A bunch of people, excited about making things a bit differently than the upstream
project forked it under a new name: «The Lounge».
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/«The Lounge»/"The Lounge"/ :-)

@astorije astorije self-assigned this Feb 24, 2016
@astorije
Copy link
Member

@almet, thanks for this!
On top of the 2 comments I left you inline, could you squash your commits please? I should be 👍 then, but the second reviewer for this should be a native speaker ideally.

@astorije astorije added the Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these. label Feb 24, 2016

This forks aims to be community managed, meaning that the decisions are taken
in a collegial fashion, and that a bunch of maintainers should be able to make
the review process more streamlined.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"more streamlined—and ideally quicker."

Thoughts, @astorije?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use words like "should" or "ideally" here actually, but more like "goal(s)", "intent", more present tense. But maybe that doesn't make any sense and therefore you should ignore this comment :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe then, "the review process quicker and more streamlined."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgw
Copy link
Contributor

dgw commented Feb 24, 2016

I'm not technically a reviewer, but I am a native English speaker. 😼

Left a couple inline comments of my own. If I was a reviewer, I'd give this a 👍 after @astorije's comments are addressed.

@almet
Copy link
Contributor Author

almet commented Feb 27, 2016

updated and squashed.

@MaxLeiter
Copy link
Member

A bunch of people, excited about doing things a bit differently than the upstream
project forked it under a new name: “The Lounge”

A bunch of people, excited about doing things a bit differently than the upstream
project, forked Shout under a new name: “The Lounge”

This fork aims to be community managed

The fork aims to be community managed

Some of my thoughts ^

@astorije
Copy link
Member

Thanks for your thoughts @MaxLeiter but I believe this is good as is :-)

@almet, 👍, thanks for this!

@xPaw
Copy link
Member

xPaw commented Feb 28, 2016

👍

astorije added a commit that referenced this pull request Feb 28, 2016
Added a section explaining why a fork was created.
@astorije astorije merged commit 27ef1f5 into thelounge:master Feb 28, 2016
@astorije astorije added this to the 1.3.0 milestone Apr 1, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Documentation Lack of documentation, improvement suggestion, or PRs that address these.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants