From 553b7e1abfd09bd44041fcd3d50a0cb3a595a6ec Mon Sep 17 00:00:00 2001 From: Tim Cross Date: Wed, 13 Jul 2022 21:07:30 +1000 Subject: [PATCH] Reverse decision to fail early on EHOSTUNREACH errors Mistake to exit early for these errors as it is possible subsequent retries may succeed i.e. temporary network failure. --- src/index.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/index.js b/src/index.js index 09b27bf..70f02dc 100644 --- a/src/index.js +++ b/src/index.js @@ -220,18 +220,17 @@ class SftpClient { switch (err.code) { case 'ENOTFOUND': case 'ECONNREFUSED': - case 'EHOSTUNREACH': case 'ERR_SOCKET_BAD_PORT': - throw err; - case undefined: { - if (err.message.endsWith('All configured authentication methods failed')) { - throw this.fmtError(err.message, 'getConnection', errorCode.badAuth); - } - retry(err); - break; + throw err; + case undefined: { + if (err.message.endsWith('All configured authentication methods failed')) { + throw this.fmtError(err.message, 'getConnection', errorCode.badAuth); } - default: - retry(err); + retry(err); + break; + } + default: + retry(err); } } });