Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove exportPattern() from NAMESPACE #311

Open
zkamvar opened this issue Jul 16, 2021 · 1 comment
Open

Remove exportPattern() from NAMESPACE #311

zkamvar opened this issue Jul 16, 2021 · 1 comment

Comments

@zkamvar
Copy link
Collaborator

zkamvar commented Jul 16, 2021

At the moment, we are using this as a kludge to export all of the functions that don't start with a dot and it's not a good practice because it makes it difficult to know what functions are for user use and what are for internal use.

Unfortunately, simply removing this breaks a lot of things as the S4 methods suddenly disappear. This is exacerbated by the fact that this package has a hybrid documentation pattern between Rd and roxygen2, which means that we have to find the source of each function and either add and #' export to it or ... something.

@zkamvar
Copy link
Collaborator Author

zkamvar commented Jul 16, 2021

I'm not going to get this for the next release, but perhaps for 2.1.5

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant