Fix nasa#262, Update inaccurate event ID name

thnkslprpt · thnkslprpt · commit 1a3de4e617ef · 2023-12-14T14:25:05.000+10:00
diff --git a/fsw/inc/cf_events.h b/fsw/inc/cf_events.h
@@ -132,7 +132,7 @@
  *
  *  Invalid message ID received on the software bus pipe
  */
-#define CF_EID_ERR_INIT_CMD_LENGTH (28)
+#define CF_MID_ERR_EID (28)
 
 /**
  * \brief CF SB Receive Buffer Failed Event ID
diff --git a/fsw/src/cf_app.c b/fsw/src/cf_app.c
@@ -302,8 +302,8 @@ void CF_ProcessMsg(CFE_SB_Buffer_t *msg)
 
         default:
             ++CF_AppData.hk.Payload.counters.err;
-            CFE_EVS_SendEvent(CF_EID_ERR_INIT_CMD_LENGTH, CFE_EVS_EventType_ERROR,
-                              "CF: invalid command packet id=0x%lx", (unsigned long)CFE_SB_MsgIdToValue(msg_id));
+            CFE_EVS_SendEvent(CF_MID_ERR_EID, CFE_EVS_EventType_ERROR, "CF: invalid command packet id=0x%lx",
+                              (unsigned long)CFE_SB_MsgIdToValue(msg_id));
             break;
     }
 }
diff --git a/fsw/src/cf_cfdp_types.h b/fsw/src/cf_cfdp_types.h
@@ -162,7 +162,6 @@ typedef enum
 
     /* keep last */
     CF_TxnStatus_MAX = 22
-
 } CF_TxnStatus_t;
 
 /**
diff --git a/unit-test/cf_app_tests.c b/unit-test/cf_app_tests.c
@@ -577,7 +577,7 @@ void Test_CF_ProcessMsg_UnrecognizedCommandEnterDefaultPath(void)
     /* Assert */
     UtAssert_UINT32_EQ(CF_AppData.hk.Payload.counters.err, 1);
     UtAssert_STUB_COUNT(CFE_EVS_SendEvent, 1);
-    UT_CF_AssertEventID(CF_EID_ERR_INIT_CMD_LENGTH);
+    UT_CF_AssertEventID(CF_MID_ERR_EID);
 }
 
 /*******************************************************************************

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@`
`132`	`132`	`*`
`133`	`133`	`* Invalid message ID received on the software bus pipe`
`134`	`134`	`*/`
`135`		`-#define CF_EID_ERR_INIT_CMD_LENGTH (28)`
	`135`	`+#define CF_MID_ERR_EID (28)`
`136`	`136`
`137`	`137`	`/**`
`138`	`138`	`* \brief CF SB Receive Buffer Failed Event ID`
Original file line number	Diff line number	Diff line change
`@@ -302,8 +302,8 @@ void CF_ProcessMsg(CFE_SB_Buffer_t *msg)`
`302`	`302`
`303`	`303`	`default:`
`304`	`304`	`++CF_AppData.hk.Payload.counters.err;`
`305`		`- CFE_EVS_SendEvent(CF_EID_ERR_INIT_CMD_LENGTH, CFE_EVS_EventType_ERROR,`
`306`		`- "CF: invalid command packet id=0x%lx", (unsigned long)CFE_SB_MsgIdToValue(msg_id));`
	`305`	`+ CFE_EVS_SendEvent(CF_MID_ERR_EID, CFE_EVS_EventType_ERROR, "CF: invalid command packet id=0x%lx",`
	`306`	`+ (unsigned long)CFE_SB_MsgIdToValue(msg_id));`
`307`	`307`	`break;`
`308`	`308`	`}`
`309`	`309`	`}`
Original file line number	Diff line number	Diff line change
`@@ -577,7 +577,7 @@ void Test_CF_ProcessMsg_UnrecognizedCommandEnterDefaultPath(void)`
`577`	`577`	`/* Assert */`
`578`	`578`	`UtAssert_UINT32_EQ(CF_AppData.hk.Payload.counters.err, 1);`
`579`	`579`	`UtAssert_STUB_COUNT(CFE_EVS_SendEvent, 1);`
`580`		`- UT_CF_AssertEventID(CF_EID_ERR_INIT_CMD_LENGTH);`
	`580`	`+ UT_CF_AssertEventID(CF_MID_ERR_EID);`
`581`	`581`	`}`
`582`	`582`
`583`	`583`	`/*******************************************************************************`