-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
micropipenv should handle issues caused by relative ordering of dependencies #12
Comments
As we might encounter similar issues when pip-tools style requirements are used, we should be capable of handling these errors in Python s2i even for requirements.txt/requirements.in. |
What if you add one more retry for the failed dependencies, but after all other builds have finished? |
+1, that's what I tried to express Currently, we install all the dependencies by exec to pip - we can install them one after another and retry the failed ones. |
Ah okay. But why the —no-deps flag? |
See #10 And more importantly - the stack present in Pipfile.lock is already fully resolved with all the dependencies pinned to specific versions. If we would install packages without Another solution is to use
Let me know if that's clear, I can come up with some example to make it more clear. |
Oh yes that makes a lot of sense. |
Describe the bug
As reported in thoth-station/s2i-thoth#39 by @4n4nd
micropipenv does not handle the relative ordering of dependencies.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
micropipenv should correctly install the dependencies
Additional context
As the stack supplied is already fully resolved the fix might be pretty simple - instead of issuing one pip installation, we can issue pip install for each package in the stack iteratively with --no-deps flag set (and fallback respecting errors).
The text was updated successfully, but these errors were encountered: