Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix CMake Build Dir Variable #14

Closed
threeal opened this issue Apr 22, 2024 · 0 comments · Fixed by #15
Closed

Fix CMake Build Dir Variable #14

threeal opened this issue Apr 22, 2024 · 0 comments · Fixed by #15
Assignees
@threeal
Labels
fix
Milestone
Version 1.0.0

Comments

@threeal
Copy link
Owner

threeal commented Apr 22, 2024

This issue suggests fixing the wrong variable utilized in this module for getting the root CMake build directory, which currently uses the CMAKE_BUILD_DIR variable. In reality, it should use the CMAKE_BINARY_DIR variable.
@threeal threeal added the fix label Apr 22, 2024
@threeal threeal added this to the Version 1.0.0 milestone Apr 22, 2024
@threeal threeal self-assigned this Apr 22, 2024
@threeal threeal added this to Granary Apr 22, 2024
@threeal threeal mentioned this issue Apr 22, 2024
Merged
@github-project-automation github-project-automation bot moved this to Harvested in Granary Apr 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@threeal threeal

Labels
fix
Projects
Granary
Status: Harvested
Milestone
Version 1.0.0
Development

Successfully merging a pull request may close this issue.

Fix CMake Build Dir Variable threeal/setup-go-cmake
1 participant
@threeal