Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

What paper or reference is the RNN implementation trying to replicate? #567

Open
5 of 8 tasks
BFAnas opened this issue Mar 11, 2022 · 1 comment
Open
5 of 8 tasks
Labels
bug Something isn't working RNN Temporary label to group all things RNN

Comments

@BFAnas
Copy link
Contributor

BFAnas commented Mar 11, 2022

  • I have marked all applicable categories:
    • exception-raising bug
    • RL algorithm bug
    • documentation request (i.e. "X is missing from the documentation.")
    • new feature request
  • I have visited the source website
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable:
    import tianshou, torch, numpy, sys
    print(tianshou.__version__, torch.__version__, numpy.__version__, sys.version, sys.platform)

0.4.6.post1 1.10.0 1.21.2 3.9.10 | packaged by conda-forge | (main, Feb 1 2022, 21:24:11)
[GCC 9.4.0] linux

Hi,

I think RNN as it is implemented right now is not working. I've been testing it with some algorithms, and these are the results I got:

  • DQN on the environments:
    1. Cartpole it learns in less than one epoch, but if it is run for more time it "forgets"
    2. Lunarlander doesn't learn
    3. MountainCar also doesn't learn
  • SAC on the environments:
    1. Ant-v3 doesn't learn
    2. HalfCheetah-v3 doesn't learn

Could you please refer me to the implementation you are trying to replicate?

@BFAnas BFAnas changed the title What paper or reference, is th RNN implementation trying to replicate? What paper or reference is the RNN implementation trying to replicate? Mar 11, 2022
@Trinkle23897 Trinkle23897 added the bug Something isn't working label Mar 12, 2022
@Trinkle23897
Copy link
Collaborator

There're known issues pointing out at #486. Unfortunately, I have no time to fix it until two months later (after graduation)...Feel free to submit PRs and I'm really sorry about that.

@MischaPanch MischaPanch added the RNN Temporary label to group all things RNN label Oct 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working RNN Temporary label to group all things RNN
Projects
None yet
Development

No branches or pull requests

3 participants