Missing assignment on random shuffle

[janpfeifer]

First of all: very nice paper! Thanks for writing it up :)

I was reading the code, and I noticed that:

PCGrad/PCGrad_tf.py

Line 36 in c5fbd7c

tf.random.shuffle(loss)

is missing an assignment (?), I think.

Don't you want to do:

loss = tf.random.shuffle(loss)

At least according to the doc here:

https://www.tensorflow.org/api_docs/python/tf/random/shuffle

cheers

[janpfeifer]

Ops, I missed the issue has already been brought up ... along with issues of the non-differentiability of tf.random.shuffle.

For others landing here:

#3

Closing the issue here.