Skip to content

Handle header parameters and non-GET requests #3

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
tidoust opened this issue Apr 11, 2018 · 0 comments
Open

Handle header parameters and non-GET requests #3

tidoust opened this issue Apr 11, 2018 · 0 comments

Comments

@tidoust
Copy link
Owner

tidoust commented Apr 11, 2018

The code assumes that only GET requests will be issued, but the package could perhaps be used in situations that require sending POST and other types of HTTP requests.

In the same vein, while the code does send additional HTTP headers provided in the call to fetch, it does not take these headers into account to search the cache entry. Sending the same GET request with two different Authorization HTTP header will likely return two different responses!

At a minimum, the README should be clear that the package does not support these scenarios for now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant