Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fill_na() --> fill_gaps() #71

Closed
earowang opened this issue Nov 16, 2018 · 0 comments
Closed

fill_na() --> fill_gaps() #71

earowang opened this issue Nov 16, 2018 · 0 comments

Comments

@earowang
Copy link
Member

earowang commented Nov 16, 2018

Three functions handle implicit missing values (time gaps): has_gaps(), count_gaps() and fill_na().

fill_na() somehow can be interpreted as "filling na with values" like tidyr::replace_na(). But this is not what fill_na() does. It attempts to fill default NA to these time gaps. Would fill_gaps() be a better name and consistent with other two functions?

@dicook @robjhyndman @mitchelloharawild

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant