Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

--dirty does not work on Windows #96

Closed
Rigby90 opened this issue Mar 16, 2023 · 2 comments
Closed

--dirty does not work on Windows #96

Rigby90 opened this issue Mar 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Rigby90
Copy link
Contributor

Rigby90 commented Mar 16, 2023

Duster appears to make use of the Project & GitPathsRepository classes from Laravel Pint to build up the array of 'dirty' files from Git.

However as Duster pins Laravel Pint to version 1.5 it does not include the fix from Pint which resolves the --dirty flag working on Windows due to the differences in slashes in directory paths.

laravel/pint#150
https://github.com/laravel/pint/releases/tag/v1.6.0

Unfortunately this doesn't look like a straight forward change from 1.5 to 1.6 due to the fact that Laravel Pint requires both PHP 8.1 (at a minimum) and Laravel Zero 10.

Unsure whether it would be easier in the short term to bring the GitPathRepository class into Duster itself to resolve the issue until such a time that Duster is updated in line with Laravel Pint.

@driftingly
Copy link
Member

Yeah, that makes sense. I've also considered updating Duster to Zero 10 and downgrading PHP when releasing.

@driftingly driftingly added the bug Something isn't working label Apr 7, 2023
@driftingly
Copy link
Member

@Rigby90 I just released version 2.0, which drops support for older versions of PHP to allow Duster to update Pint.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants