Encode URLs?

[reinink]

I ran into a situation today where I was using user-generated input to generate URLs with Ziggy. For example:

route('user.search', { ...my search params... })

However, if a user types in any character that has a special URL meaning (ie. an ampersand), then this URL is busted.

For example, if I search for "Jonathan&Amy", I'll get:

/users?search=Jonathan&Amy

Since the ampersand is a query string separator, my search value will only be "Jonathan".

A simple solution here would be to simply encode the URL when generating it using encodeURIComponent(). More info here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent.

[reinink]

Awesome, thanks @DanielCoulbourne!

[reinink]

@DanielCoulbourne I'm not sure what's wrong, but I'm not seeing the new encodeURIComponent stuff when I actually call @routes. Did we miss a step here? Maybe some build step?

[DanielCoulbourne]

Oh that makes sense... I'll fix that in a few.

[avrahamappel]

Can we encode the keys as well as the values? So if I have

/fields[foo]=bar

it should become

/fields%5Bfoo%5D%3Dbar