Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): bump prost to 0.12 #636

Closed
wants to merge 4 commits into from
Closed

Conversation

waynexia
Copy link

closes #635

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
Copy link
Author

I've checked this with cargo check --workspace -F prost-codec in my env. PTAL @BusyJay

@BusyJay
Copy link
Member

BusyJay commented Nov 7, 2023

You need to regenerate all sources after upgrading prost-build.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
Copy link
Author

waynexia commented Nov 7, 2023

Thanks for your guide. I've run cargo xtask codegen and pushed the changes 👍

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
Copy link
Author

waynexia commented Nov 7, 2023

Have the following commands passed:

cargo clippy --all -- -D clippy::all && cargo clippy --all --no-default-features --features prost-codec -- -D clippy::all
cd proto && cargo build --no-default-features --features prost-codec

PLTA again 🥲

@BusyJay
Copy link
Member

BusyJay commented May 7, 2024

Should be covered by #648. Thanks for your contribution!

@BusyJay BusyJay closed this May 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump prost to 0.12
2 participants