Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Promote Learner need not panic on failure condition. #89

Closed
Hoverbear opened this issue Jul 9, 2018 · 1 comment
Closed

Promote Learner need not panic on failure condition. #89

Hoverbear opened this issue Jul 9, 2018 · 1 comment
Labels
Enhancement An improvement to existing code. Good First Issue A good issue for a new contributor.
Milestone
0.4.0

Comments

@Hoverbear
Copy link
Contributor

Hoverbear commented Jul 9, 2018 •
edited
Loading

Currently promote_leader can panic on a failure case.

https://github.com/pingcap/raft-rs/blob/1e0741a9aea3b242d33dadc46245ad611e7e7aa4/src/progress.rs#L129-L136

This issue would be solved if promote_leader() instead returned a value such as Result<()> so the calling code can handle the situation.
@Hoverbear Hoverbear added Enhancement An improvement to existing code. Good First Issue A good issue for a new contributor. labels Jul 9, 2018
@Hoverbear Hoverbear mentioned this issue Jul 9, 2018
Merged
@Hoverbear
Copy link
Contributor Author

This is resolved in #102

@Hoverbear Hoverbear added this to the 0.4.0 milestone Aug 24, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Enhancement An improvement to existing code. Good First Issue A good issue for a new contributor.
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@Hoverbear