Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stale read when using read_index request #9351

Closed
BusyJay opened this issue Dec 24, 2020 · 6 comments · Fixed by #9549
Closed

Stale read when using read_index request #9351

BusyJay opened this issue Dec 24, 2020 · 6 comments · Fixed by #9549
Assignees
Labels
severity/major sig/raft Component: Raft, RaftStore, etc. type/bug The issue is confirmed as a bug.

Comments

@BusyJay
Copy link
Member

BusyJay commented Dec 24, 2020

Bug Report

Similar to #9208, ReadIndex request can be given a stale index after just transferring leader. The API doesn't seem to be used anymore, so the best way to solve it is removing the API completely.

@NingLin-P @gengliqi PTAL

/cc @solotzg, just make sure tiflash will not use the API in the future.

@BusyJay BusyJay added type/bug The issue is confirmed as a bug. sig/raft Component: Raft, RaftStore, etc. labels Dec 24, 2020
@solotzg
Copy link
Contributor

solotzg commented Dec 24, 2020

Since 4.0.8, tiflash won't use ReadIndex to get read-index from leader directly.

@BusyJay
Copy link
Member Author

BusyJay commented Dec 24, 2020

I remember there is a solution to use proxy to do reading across DC, which also use read index. @hicqu Is it still a valid solution? Is the stale read proposal a good alternative to it?

@hicqu
Copy link
Contributor

hicqu commented Dec 24, 2020

@BusyJay that solution is paused and I think the stale read proposal is more useful than that.

Is it necessary to fix the bug for TiFlash ^4.0.7? If so we need to fix it, or we can remove the API directly.

@BusyJay
Copy link
Member Author

BusyJay commented Dec 24, 2020

The only way to fix for them is using a hotfix. I suggest to ask them to upgrade to v4.0.9 instead.

@hicqu
Copy link
Contributor

hicqu commented Jan 20, 2021

Can it be closed now?

@BusyJay
Copy link
Member Author

BusyJay commented Jan 20, 2021

Why? The API still exists and it can return wrong result.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
severity/major sig/raft Component: Raft, RaftStore, etc. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants