Fix cagg_migrate_to_time_bucket during update #7763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7763 +/- ##
==========================================
+ Coverage 80.06% 81.92% +1.86%
==========================================
Files 190 247 +57
Lines 37181 45430 +8249
Branches 9450 11355 +1905
==========================================
+ Hits 29770 37220 +7450
- Misses 2997 3741 +744
- Partials 4414 4469 +55 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
fix_cagg_migrate_to_time_bucket_during_update
branch
from
58ce092 to
860cb3f
Compare
erimatnor
approved these changes
Feb 21, 2025
In timescale#6837 we added a migration for CAggs using `time_bucket_ng` to use the new version of `time_bucket` that support orign and/or offset. We made a mistake because we place the code to migrate existing CAggs using `time_bucket_ng` to `time_bucket` in the update script but this code should be placed instead on post-update.sql script where we can call functions from the new extension version loaded.
fabriziomello
force-pushed
the
fix_cagg_migrate_to_time_bucket_during_update
branch
from
860cb3f to
b18e3ca
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6837 we added a migration for CAggs using
time_bucket_ngto use the new version oftime_bucketthat support orign and/or offset.We made a mistake because we place the code to migrate existing CAggs using
time_bucket_ngtotime_bucketin the update script but this code should be placed instead on post-update.sql script where we can call functions from the new extension version loaded.Disable-check: force-changelog-file