Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Small bug when selex of oldest age = 0 and N1_model = 1 is used #56

Closed
GiancarloMCorrea opened this issue Apr 20, 2022 · 2 comments
Closed

Comments

@GiancarloMCorrea
Copy link

Here: https://github.com/timjmiller/wham/blob/master/src/wham_v0.cpp

A selectivity value in line 687 equals zero for the oldest age and for all fleets will cause that FAA_tot(0,n_ages-1) equals zero, so we would have a zero in the denominator in lines 718 and 719. This might be fixed by adding a small constant (1E-03) to the denominator?

@timjmiller
Copy link
Owner

Thanks! Yes, it should use the value in which_F_age (line 72), similar to the use on line 1230.
I will make this modification to devel branch and reply and close when it is available.

@timjmiller
Copy link
Owner

timjmiller commented May 5, 2022

This has been fixed on devel branch 4588fc3.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants