Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FR: Generate better diff images #10

Open
tingerrr opened this issue Jan 27, 2024 · 0 comments
Open

FR: Generate better diff images #10

tingerrr opened this issue Jan 27, 2024 · 0 comments
Labels
A-comparison Area: test reference comparison A-diagnostics Area: error reporting A-tests Area: anything actually test related C-feature Category: feature request P-low Priority: low
Milestone

Comments

@tingerrr
Copy link
Owner

When generating a diff image, the following things could be improved:

  • generate diff images on a page size mismatch (Diff images are not being generated for page size differences #8)
  • highlight changes, bounding boxes of small change sets can be created very easily using a border finding algorithm (see for example Suzuki and Abe 1)
  • highlight which kind of change it is
    • red: deletion from reference to output
    • green: addition from reference to output
  • overlay these boxes on the output or reference image to make it easier to visually compare

Footnotes

  1. https://www.nevis.columbia.edu/~vgenty/public/suzuki_et_al.pdf

@tingerrr tingerrr added the C-feature Category: feature request label Jan 27, 2024
@tingerrr tingerrr added this to the Rewrite milestone Jun 16, 2024
@tingerrr tingerrr added the P-low Priority: low label Jun 26, 2024
@tingerrr tingerrr modified the milestones: Rewrite, Release 0.1.0 Jul 19, 2024
@tingerrr tingerrr modified the milestones: Release 0.1.0, 0.2.0 Jan 16, 2025
@tingerrr tingerrr changed the title Generate better diff images FD: Generate better diff images Jan 25, 2025
@tingerrr tingerrr changed the title FD: Generate better diff images FR: Generate better diff images Feb 1, 2025
@tingerrr tingerrr added A-diagnostics Area: error reporting A-comparison Area: test reference comparison A-tests Area: anything actually test related and removed A-reporting labels Feb 2, 2025
@tingerrr tingerrr modified the milestones: 0.2.0, 0.3.0+, Backlog, 0.3.0 Feb 11, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-comparison Area: test reference comparison A-diagnostics Area: error reporting A-tests Area: anything actually test related C-feature Category: feature request P-low Priority: low
Projects
None yet
Development

No branches or pull requests

1 participant