Skip to content

Commit 77f9b15

Browse files
authored
Merge pull request emscripten-core#22 from rstz/minor-fixes
Remove spam from file packager script and fix main thread prejs
2 parents 2b735d1 + be929d2 commit 77f9b15

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed
Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
if ("preRun" in Module) {
2-
Module["preRun"].push(async () => {
3-
await PThreadFS.init('persistent');
4-
await PThreadFS.writeFile("persistent/file.txt", "the contents of persistent/file.txt !!", {});
5-
await PThreadFS.createPath("/", "persistent/mainthreadfolder/subfolder/", true, true);
6-
await PThreadFS.writeFile("persistent/mainthreadfolder/subfolder/ok now",
7-
"the contents of persistent/mainthreadfolder/subfolder/ok now !!", {});
2+
Module["preRun"].push( () => {
3+
addRunDependency('writeFiles');
4+
PThreadFS.init('persistent').then(async () => {
5+
await PThreadFS.writeFile("persistent/file.txt", "the contents of persistent/file.txt !!", {});
6+
await PThreadFS.createPath("/", "persistent/mainthreadfolder/subfolder/", true, true);
7+
await PThreadFS.writeFile("persistent/mainthreadfolder/subfolder/ok now",
8+
"the contents of persistent/mainthreadfolder/subfolder/ok now !!", {});
9+
removeRunDependency('writeFiles');
10+
});
811
});
912
}

pthreadfs/file_packager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -518,12 +518,13 @@ def was_seen(name):
518518
var that = this;
519519
520520
// Remove potential old versions of this file.
521+
// TODO: Consider only removing if the file exists, for performance.
521522
try {
522523
await PThreadFS.unlink(this.name);
523524
}
524525
catch (e) {
525-
// TODO: This error message might spam the console, consider removing it when the file packager matures.
526-
console.log("Removing " + this.name + " failed with message " + e);
526+
// Emitting an error will spam the console with unnecessary messages.
527+
// console.log("Removing " + this.name + " failed with message " + e);
527528
}
528529
await PThreadFS.createDataFile(this.name, null, byteArray, true, true,
529530
true); // canOwn this data in the filesystem, it is a slide into the heap that will

tools/file_packager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -518,12 +518,13 @@ def was_seen(name):
518518
var that = this;
519519
520520
// Remove potential old versions of this file.
521+
// TODO: Consider only removing if the file exists, for performance.
521522
try {
522523
await PThreadFS.unlink(this.name);
523524
}
524525
catch (e) {
525-
// TODO: This error message might spam the console, consider removing it when the file packager matures.
526-
console.log("Removing " + this.name + " failed with message " + e);
526+
// Emitting an error will spam the console with unnecessary messages.
527+
// console.log("Removing " + this.name + " failed with message " + e);
527528
}
528529
await PThreadFS.createDataFile(this.name, null, byteArray, true, true,
529530
true); // canOwn this data in the filesystem, it is a slide into the heap that will

0 commit comments

Comments
 (0)