-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use ConfigureAwait(false) for all awaits #59
Comments
No, it wasn't deliberate. I would accept a PR. I still would never recommend using AsyncPoco unless all calls are made synchronously (stick with PetaPoco or something else in that case). Also note that if you're using ASP.NET Core, |
Sorry for the delay. Looks good to me, I'll get it released. Thanks! |
This has been released and published to NuGet in 2.0.2 |
Thank you! 👍 |
To avoid deadlocks when forced to block on async code (for example, when migrating from a mostly synchronous codebase to
async
/await
), and for performance reasons, it would be helpful to addConfigureAwait(false)
whereverawait
is used (Async/Await - Best Practices in Asynchronous Programming).Was it a deliberate decision not to use
ConfigureAwait(false)
, or would you be open to a PR adding this to all async calls?The text was updated successfully, but these errors were encountered: