Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rome not failing when engine exit code is not zero #236

Open
acecilia opened this issue Dec 11, 2020 · 1 comment
Open

Rome not failing when engine exit code is not zero #236

acecilia opened this issue Dec 11, 2020 · 1 comment

Comments

@acecilia
Copy link

Rome version: 0.23.3.64
OS: catalina 10.15.7

Hi 👋

Problem

Rome is not failing when the engine exists with a code different than zero.

Expectation

When the engine returns an exit code different than zero, Rome should also fail and exit with a code different than zero. For example, using the default google engine from this repository:

        print(f"{remote_path} 404'ed")
        zip_file_path.unlink()
        exit(1)

If such code path gets executed, Rome should fail instead of continuing execution

@tmspzz
Copy link
Owner

tmspzz commented Dec 17, 2020

Thanks for reporting. I'll take a look

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants