test failures with Rust 1.84 and newer #109

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open

decathorpe opened this issue Jan 22, 2025 · 0 comments

Contributor

decathorpe commented Jan 22, 2025 •

edited

Loading

---- ascii_char::tests::is_digit_strange_radixes stdout ----
thread 'ascii_char::tests::is_digit_strange_radixes' panicked at (...)/rustc-1.84.0-src/library/core/src/char/methods.rs:391:9:
to_digit: invalid radix -- radix must be in the range 2 to 36 inclusive
failures:
    ascii_char::tests::is_digit_strange_radixes

This seems to be caused by a behaviour change in the Rust standard library as of version 1.84.0 (Pull Request, commit).

Would it make sense to follow the standard library here, and forbid invalid radixes 0 and 1?

The text was updated successfully, but these errors were encountered:

# for free to join this conversation on GitHub. Already have an account? # to comment