Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WebSocket support should be runtime-independent #367

Closed
vorot93 opened this issue Aug 3, 2020 · 1 comment · Fixed by #368
Closed

WebSocket support should be runtime-independent #367

vorot93 opened this issue Aug 3, 2020 · 1 comment · Fixed by #368

Comments

@vorot93
Copy link
Contributor

vorot93 commented Aug 3, 2020

Right now it requires async-std, but in mere executor capacity. Maybe employ this approach?

paritytech/jsonrpsee#102

@tomusdrw
Copy link
Owner

tomusdrw commented Aug 7, 2020

Addressed by compilation features, I think it's more elegant, since some dependencies are not capable of simply switching between runtimes at the run time (i.e. they have compilation features as well).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants