getSecureRandomNumber will return min - 1 for big numbers

[XantreDev]

I've didn't encountered this problem in real life (in ton wallet creation use case). But I would like to report it anyway

Problem

This code throws an exeception for bits size more than 53. But actually it should throw bit size more than 31

Why?

Because bits manipulations with JS number are restricted by 32 bit integer type. Left operand cast to integer happens every time when "|", "&" or "^" is applied to it.

for (let bits = 30; bits < 40; ++bits) {
    console.log(bits, (Math.pow(2, bits) - 1) & (Math.pow(2, bits) - 1))
}

So for a big number this code will return min-1

numberValue = numberValue & mask; // Truncate = -1
if (numberValue >= range) {
  continue;
}
return min + numberValue; // min + (-1)

[XantreDev]

getSecureRandomBytes(bitsNeeded) I think should be called from bytesNeeded, because we iterate only first bytesNeeded elements

[Milon20232024]

0xc6989369843C2f0A9D10429E21e2cFdF8BFa1Eb9