Possible issue with pki function when dy is non-zero causes gauge to calculate arc path wrong

[devmonkey22]

I am using version dated 31/07/2012 version 1,0.

I think I found an issue where the pki function miscalculates the Yo and Yi values when dy is non-zero. For example, Yo's calculation is "h - (h - Cy) + dy - Ro * Math.sin(alpha)" however I believe that dy should be removed because Cy already translates Cy by dy, so Yo was being double translated by dy in effect. Same goes for Yi.

Thanks,
Mike Dearman

[toorshia]

Wow. Nice catch...
Before I warm up my forgotten math skills and dive into code, can you demonstrate the issue? :)

Thanks!

[devmonkey22]

Ya, it took some time to dig into the math for us too..
I created two sample files – one with the issue, one with it fixed (which includes the fixed js file).
I'm not sure how to get the samples over to you though.

As a synopsis, I used the auto-adjust.htm sample, changed g1's height to 375px.
To fix, I removed the "+ dy" part when calculating Yo and Yi.

Mike

[toorshia]

#245