New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

classDist test is flaky #1352

Open

MichaelChirico opened this issue Oct 2, 2023 · 0 comments

Contributor

MichaelChirico commented Oct 2, 2023

caret/pkg/caret/tests/testthat/test_classDist.R

Line 64 in 5f4bd20

expect_true(length(distData$values) == length(unique(y)) - 1)

res <- replicate(1e4, {
  trainSet <- sample(1:150, 100)
  x = iris[trainSet, 1:4]
  y = as.numeric(iris$Species[trainSet])
  groups = 4

  distData <- classDist(x, y, pca = FALSE, groups = groups)
  length(distData$values) == length(unique(y)) - 1
})
table(res)
# res
# FALSE  TRUE 
#    21  9979

How can we decrease the flakiness here?

# for free to join this conversation on GitHub. Already have an account? # to comment