Skip to content

Commit e0fa53e

Browse files
authored
Merge pull request #3257 from bdarnell/build-workflow-wstest-warning
test: Close a websocket client that causes occasional test failures
2 parents fcb09eb + f5a1d5c commit e0fa53e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/build.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
name: Upload to PyPI (test)
6969
needs: [build_wheels, build_sdist]
7070
runs-on: ubuntu-22.04
71-
if: github.event_name == 'push' && startsWith(github.ref_name, 'build-workflow')
71+
if: github.repository == 'tornadoweb/tornado' && github.event_name == 'push' && startsWith(github.ref_name, 'build-workflow')
7272
steps:
7373
- uses: actions/download-artifact@v3
7474
with:
@@ -86,7 +86,7 @@ jobs:
8686
name: Upload to PyPI (prod)
8787
needs: [build_wheels, build_sdist]
8888
runs-on: ubuntu-22.04
89-
if: github.event_name == 'push' && github.ref_type == 'tag' && startsWith(github.ref_name, 'v')
89+
if: github.repository == 'tornadoweb/tornado' && github.event_name == 'push' && github.ref_type == 'tag' && startsWith(github.ref_name, 'v')
9090
steps:
9191
- uses: actions/download-artifact@v3
9292
with:

tornado/test/websocket_test.py

+1
Original file line numberDiff line numberDiff line change
@@ -807,6 +807,7 @@ def test_client_ping(self):
807807
response = yield ws.read_message()
808808
self.assertEqual(response, "got ping")
809809
# TODO: test that the connection gets closed if ping responses stop.
810+
ws.close()
810811

811812

812813
class ManualPingTest(WebSocketBaseTestCase):

0 commit comments

Comments
 (0)