From edc8117a7e19a03e84fe15857e8254b9c3753055 Mon Sep 17 00:00:00 2001 From: Kemal Zebari Date: Fri, 28 Jun 2024 14:16:04 -0700 Subject: [PATCH] Use is_missing property in ReqPackage.is_conflicting() for DRYness --- src/pipdeptree/_models/package.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/pipdeptree/_models/package.py b/src/pipdeptree/_models/package.py index 6949abf..af98d60 100644 --- a/src/pipdeptree/_models/package.py +++ b/src/pipdeptree/_models/package.py @@ -226,18 +226,18 @@ def installed_version(self) -> str: return v return self.dist.version - @property - def is_missing(self) -> bool: - return self.installed_version == self.UNKNOWN_VERSION - def is_conflicting(self) -> bool: """If installed version conflicts with required version.""" # unknown installed version is also considered conflicting - if self.installed_version == self.UNKNOWN_VERSION: + if self.is_missing: return True return self.installed_version not in self._obj.specifier + @property + def is_missing(self) -> bool: + return self.installed_version == self.UNKNOWN_VERSION + def as_dict(self) -> dict[str, str]: return { "key": self.key,