From dfd89b981d9607833d6cca9e2b789044c5ff848e Mon Sep 17 00:00:00 2001 From: Samuel Moelius Date: Sat, 30 Nov 2024 14:27:16 -0500 Subject: [PATCH 1/2] Refine `LINE_WITH_TIME_RE` To allow Necessist to work with Mocha tests ending in `(`...`)`. This is a bandaid. A better approach would be to disable printing of times altogether. However, this appears to be an open issue for Hardhat: - https://github.com/NomicFoundation/hardhat/issues/4307 - https://github.com/NomicFoundation/hardhat/issues/4314 --- backends/src/ts/mocha/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/src/ts/mocha/mod.rs b/backends/src/ts/mocha/mod.rs index a067b98c..aac3906c 100644 --- a/backends/src/ts/mocha/mod.rs +++ b/backends/src/ts/mocha/mod.rs @@ -62,7 +62,7 @@ impl Default for ItMessageState { static LINE_WITH_TIME_RE: Lazy = Lazy::new(|| { // smoelius: The initial `.` is the check mark. #[allow(clippy::unwrap_used)] - Regex::new(r"^\s*. (.*) \(.*\)$").unwrap() + Regex::new(r"^\s*. (.*) \([0-9]+ms\)$").unwrap() }); static LINE_WITHOUT_TIME_RE: Lazy = Lazy::new(|| { From 2db452f9119468725e2f7f138b6b733f6b6fdde5 Mon Sep 17 00:00:00 2001 From: Samuel Moelius Date: Sun, 1 Dec 2024 08:36:46 -0500 Subject: [PATCH 2/2] Disable `squads-protocol_v4` third-party test Until the following issue is resolved: https://github.com/Squads-Protocol/v4/issues/140 --- necessist/tests/README.md | 1 - .../1/{squads-protocol_v4.toml => squads-protocol_v4.toml~} | 0 2 files changed, 1 deletion(-) rename necessist/tests/third_party_tests/1/{squads-protocol_v4.toml => squads-protocol_v4.toml~} (100%) diff --git a/necessist/tests/README.md b/necessist/tests/README.md index 08e45ad9..2ac6b35e 100644 --- a/necessist/tests/README.md +++ b/necessist/tests/README.md @@ -20,6 +20,5 @@ | proptest_https | b71253807372932f72a71b1af7975371a41e7c88 | | X | X | X | X | 0 | | pyth | | anchor | | X | X | | 0 | | seaport | 1.6 | hardhat | | X | X | X | 1 | -| squads-protocol_v4 | 19597dc082986d7d95a89ee124dc23625b1b0039 | anchor | X | X | X | | 1 | | uniswap_v3-core | | | | X | X | X | 0 | | uniswap_v3-core_factory | | | X | X | X | X | 1 | diff --git a/necessist/tests/third_party_tests/1/squads-protocol_v4.toml b/necessist/tests/third_party_tests/1/squads-protocol_v4.toml~ similarity index 100% rename from necessist/tests/third_party_tests/1/squads-protocol_v4.toml rename to necessist/tests/third_party_tests/1/squads-protocol_v4.toml~