Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

validate logger level #213

Closed
ycpatel813 opened this issue Jun 22, 2016 · 3 comments
Closed

validate logger level #213

ycpatel813 opened this issue Jun 22, 2016 · 3 comments

Comments

@ycpatel813
Copy link

ycpatel813 commented Jun 22, 2016

Issue Description

logger: new winston.Logger({
    level: 'debgu',
    exitOnError: false,
    transports: [
      new (winston.transports.Console)({
        prettyPrint: true,
        colorize: true
      })
    ]
  })

by mistake i wrote dubgu in logger level after that trails app did not start and did not respose any error message
so it is useful that trails validate logger level

Environment

  • node version: v4.4.4
  • trails version: ^1.0.0-beta-1
  • operating system: Window 7
@jaumard
Copy link
Contributor

jaumard commented Jun 22, 2016

We have to find a way to test/detect this... Because we can't validate the logger level because the logger can be any logger (not Winston) and then level will be not defined.

@tjwebb
Copy link
Member

tjwebb commented Jun 26, 2016

Yea, this is hard. The level is being sent into Winston as an argument, and isn't directly accessible to the application.

@tjwebb
Copy link
Member

tjwebb commented Nov 22, 2016

Continued in #261.

@tjwebb tjwebb closed this as completed Nov 22, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants