Skip to content
This repository was archived by the owner on Apr 1, 2023. It is now read-only.

Upgrading to babel 7 #86

Closed
sag1v opened this issue Oct 14, 2018 · 10 comments · Fixed by #103
Closed

Upgrading to babel 7 #86

sag1v opened this issue Oct 14, 2018 · 10 comments · Fixed by #103

Comments

@sag1v
Copy link

sag1v commented Oct 14, 2018

@transitive-bullshit What do you say, can we move on to babel 7?

@transitive-bullshit
Copy link
Owner

Definitely 👍

@sag1v
Copy link
Author

sag1v commented Oct 16, 2018

@transitive-bullshit cool. You prefer to do it yourself or should i submit a PR? (I think i have time later on this week)

@tchalvak
Copy link

That would be a good upgrade to PR!

@sag1v
Copy link
Author

sag1v commented Nov 22, 2018

@transitive-bullshit
I've created #103, can you test it on your end?

@ravecat
Copy link

ravecat commented Mar 26, 2019

@transitive-bullshit @sag1v As I understand docs https://github.com/rollup/rollup-plugin-babel#helpers doesn't match current configs. Could you clarify how use transform-runtime plugin? Can I exclude it and reduce bundle size?

@coryhouse
Copy link

I see this was merged, but when i run npx create-react-library, it creates a project using Babel 6. Is that a bug?

@sag1v
Copy link
Author

sag1v commented Jul 6, 2019

@coryhouse As far as i know this was published to npm. What version you see installed?

@coryhouse
Copy link

I'd suggest running the command on your machine. Here's the package.json it generated:

{
  "name": "test",
  "version": "1.0.0",
  "description": "test",
  "author": "coryhouse",
  "license": "None",
  "repository": "coryhouse/test",
  "main": "dist/index.js",
  "module": "dist/index.es.js",
  "jsnext:main": "dist/index.es.js",
  "engines": {
    "node": ">=8",
    "npm": ">=5"
  },
  "scripts": {
    "test": "cross-env CI=1 react-scripts test --env=jsdom",
    "test:watch": "react-scripts test --env=jsdom",
    "build": "rollup -c",
    "start": "rollup -c -w",
    "prepare": "npm run build",
    "predeploy": "cd example && npm install && npm run build",
    "deploy": "gh-pages -d example/build"
  },
  "peerDependencies": {
    "prop-types": "^15.5.4",
    "react": "^15.0.0 || ^16.0.0",
    "react-dom": "^15.0.0 || ^16.0.0"
  },
  "devDependencies": {
    "@svgr/rollup": "^2.4.1",
    "babel-core": "^6.26.3",
    "babel-eslint": "^8.2.5",
    "babel-plugin-external-helpers": "^6.22.0",
    "babel-preset-env": "^1.7.0",
    "babel-preset-react": "^6.24.1",
    "babel-preset-stage-0": "^6.24.1",
    "cross-env": "^5.1.4",
    "eslint": "^5.0.1",
    "eslint-config-standard": "^11.0.0",
    "eslint-config-standard-react": "^6.0.0",
    "eslint-plugin-import": "^2.13.0",
    "eslint-plugin-node": "^7.0.1",
    "eslint-plugin-promise": "^4.0.0",
    "eslint-plugin-react": "^7.10.0",
    "eslint-plugin-standard": "^3.1.0",
    "gh-pages": "^1.2.0",
    "react": "^16.4.1",
    "react-dom": "^16.4.1",
    "react-scripts": "^1.1.4",
    "rollup": "^0.64.1",
    "rollup-plugin-babel": "^3.0.7",
    "rollup-plugin-commonjs": "^9.1.3",
    "rollup-plugin-node-resolve": "^3.3.0",
    "rollup-plugin-peer-deps-external": "^2.2.0",
    "rollup-plugin-postcss": "^1.6.2",
    "rollup-plugin-url": "^1.4.0"
  },
  "files": [
    "dist"
  ]
}

@sag1v
Copy link
Author

sag1v commented Jul 6, 2019

No sorry, i meant what version of creat-react-library is installed on your machine?

EDIT
I see that the latest published version 2.6.7 is generating the same devDependencies indeed.
I was sure this one shipped to prod already, i guess i was wrong.

@transitive-bullshit Wasn't this merge published to npm, or you want to combine it with the WIP of #136 (crl-scripts)?

@letalumil
Copy link

Any plans to publish the update to npm?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants