Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve display syscall verification #4273

Open
TychoVrahe opened this issue Oct 21, 2024 · 0 comments · May be fixed by #4683
Open

Improve display syscall verification #4273

TychoVrahe opened this issue Oct 21, 2024 · 0 comments · May be fixed by #4683
Labels
code Code improvements
Milestone
MCU preparation f...

Comments

@TychoVrahe
Copy link
Contributor

Followup for #4229

The current verifiers display_fill__verified and display_copy_rgb565__verified are not checking the destination write access.

We need to ensure that these functions cannot be misused to write outside of designated framebuffer area by improperly set bitblt structure.

See also #4229 (comment)
@TychoVrahe TychoVrahe added the code Code improvements label Oct 21, 2024
@TychoVrahe TychoVrahe mentioned this issue Oct 21, 2024
Merged
@cepetr cepetr linked a pull request Feb 27, 2025 that will close this issue
Open
@TychoVrahe TychoVrahe linked a pull request Feb 27, 2025 that will close this issue
DMA2D syscalls #4683
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
code Code improvements
Projects
Firmware
Status: No status
Milestone
MCU preparation for FW modularization
Development

Successfully merging a pull request may close this issue.

DMA2D syscalls trezor/trezor-firmware
1 participant
@TychoVrahe