Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Message box/area not resizing properly #85

Open
cyanea-bt opened this issue Jun 19, 2024 · 1 comment · May be fixed by #86
Open

Message box/area not resizing properly #85

cyanea-bt opened this issue Jun 19, 2024 · 1 comment · May be fixed by #86

Comments

@cyanea-bt
Copy link

Describe the issue
After a long TextMessage the message box/area won't shrink back down for shorter messages.
This bug was introduced in commit ab18b96, previous versions work fine (e.g. 1d85062)

Expected behaviour
Message box/area should resize properly for each new TextMessage.

Steps to reproduce
Always happens, no special setup needed. Game version is DRM-free re-release.
If you need logs to figure out the cause, just let me know how to produce them.

Additional information

  • Level: Any (tested multiple tutorials)
  • Graphics fix: dgVoodoo2_82_5
  • Using mods: None

older versions (e.g. 1d85062):
long message:
2024-06-19_tutorial7_#1d85062_working_step1
next message after:
2024-06-19_tutorial7_#1d85062_working_step2


versions after ab18b96:
long message:
2024-06-19_tutorial7_#ab18b96_NOT_working_step1
next message after:
2024-06-19_tutorial7_#ab18b96_NOT_working_step2

@cyanea-bt
Copy link
Author

Found the cause for the resizing issues. The formula used for textGlobs.winLowPos was incomplete.
I'll open a PR for the fix.

@cyanea-bt cyanea-bt linked a pull request Jun 24, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant