Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Catchup on extension conflicts #7

Closed
lextm opened this issue Aug 28, 2021 · 1 comment · Fixed by #6
Closed

Catchup on extension conflicts #7

lextm opened this issue Aug 28, 2021 · 1 comment · Fixed by #6

Comments

@lextm
Copy link
Contributor

lextm commented Aug 28, 2021

Like you proposed in this thread, it is possible to allow the two extensions to co-exist.

However, the two extensions at this moment effectively define two languages (rst and restructuredtext). So if the end users install them in a specific order (mine first and then yours), everything works as expected. But if the order is reversed (yours first and then mine), then only yours take effect.

You might use the attached VSIX (syntax highlighting removed inside) to test the installation order out.
restructuredtext-158.0.0.vsix.zip

It is rather complicated to change the identifier in my extension (as it has far too many references) while easy to change yours, so I sent a pull request in #6 and hope that you might consider it.

Changing the identifier does not break your end users in general. But if they use yours along with other extensions for rst language, then they will unfornately observe the same conflicts.

@trond-snekvik
Copy link
Owner

Seems like a good solution to me. I'll merge the two PRs and make a new release this afternoon 🙂

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants